feat: clean up cached preprocessed audio after unittests #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamuelLarkin
force-pushed
the
dev.sl/haunting_ghosts
branch
from
b986723
to
485f6b4
Compare
SamuelLarkin
force-pushed
the
dev.sl/extraneous_files
branch
2 times, most recently
from
7b7d4e2
to
9bf125e
Compare
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #386 +/- ##
=======================================
Coverage 73.15% 73.15%
=======================================
Files 43 43
Lines 2786 2786
Branches 459 459
=======================================
Hits 2038 2038
Misses 664 664
Partials 84 84 ☔ View full report in Codecov by Sentry. |
SamuelLarkin
force-pushed
the
dev.sl/extraneous_files
branch
from
27aa800
to
6416c6e
Compare
SamuelLarkin
changed the title
SamuelLarkin
requested review from
roedoejet and
joanise
and removed request for
roedoejet
SamuelLarkin
changed the title
joanise
reviewed
Apr 16, 2024
everyvoice/tests/test_dataloader.py
Outdated
| """Basic test for dataloaders""" | ||
|
|
||
| lj_preprocessed = PreprocessingTest.lj_preprocessed | ||
|
|
||
| # FIXME: Shouldn't this be done only one for this class and not for every test? |
There was a problem hiding this comment.
Depends... do any of the tests modify self.config?
There was a problem hiding this comment.
Actually, may be we should play it safe and keep creating a new self.config in setUp() as it surely isn't expansive to do and it would prevent future headaches in the advent that a new test case does change self.config.
SamuelLarkin
force-pushed
the
dev.sl/haunting_ghosts
branch
2 times, most recently
from
9795592
to
26365ba
Compare
SamuelLarkin
force-pushed
the
dev.sl/extraneous_files
branch
from
6416c6e
to
427bc8b
Compare
SamuelLarkin
force-pushed
the
dev.sl/extraneous_files
branch
from
427bc8b
to
df4f5f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.