-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Praat TextGrid as possible synthesis output #436
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #436 +/- ##
==========================================
- Coverage 73.94% 73.89% -0.06%
==========================================
Files 43 43
Lines 2618 2620 +2
Branches 404 405 +1
==========================================
Hits 1936 1936
- Misses 602 603 +1
- Partials 80 81 +1 ☔ View full report in Codecov by Sentry. |
|
Do we have any unit testing covering this? Based on the line that's not covered in this PR, I'm guessing there is not. It would be really important to add at least minimal testing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good except we need to exercise this code in CI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
I played with it a little bit. It generated a text-grid file. I was able to open it using PRAAT. side node: I did not look at all the finer details of the text-grid file yet... but good to go for a first release! |
Thanks all! You're right @joanise - I've made an issue |
e40d84b
to
de413a7
Compare
PR Goal?
Add the option to synthesize Praat TextGrids using the predicted durations. This lays the foundation for adding a .readalong callback (@joanise 😉 )
As an example (produced with this PR):
Fixes?
#435
Feedback sought?
Try it out! Sanity check
Priority?
Medium
Tests added?
Still need to do this...
How to test?
add the
-O textgrid
to the synthesize command (instead ofspec
orwav
as previously)Confidence?
high - I've been testing this out
Version change?
N/A
Related PRs?
EveryVoiceTTS/FastSpeech2_lightning#80