Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing everyvoice.tests.test_utls #479

Merged
merged 5 commits into from
Jun 20, 2024
Merged

Conversation

SamuelLarkin
Copy link
Collaborator

@SamuelLarkin SamuelLarkin commented Jun 20, 2024

PR Goal?

Eric noticed that running the unittests would leave a directory metadata.psv/ where ever you ran the unittests.
Note, that investigating this issue, I realized why the disabled tests marked WIP_* didn't work.
Those tests use a BaseModel and a context and the derived classes were missing a custom __init__() to propagate the context.

Fixes?

fixes: #457

Feedback sought?

Approval to merge

Priority?

Low

Tests added?

Yes under everyvoice.tests.test_utils, but mostly reordering of test methods.

How to test?

python -m unittest everyvoice.tests.test_utils

Confidence?

high

Version change?

no

Related PRs?

none

@SamuelLarkin SamuelLarkin changed the title [WIP] Fixing everyvoice.tests.test_utls Fixing everyvoice.tests.test_utls Jun 20, 2024
Copy link
Member

@joanise joanise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This patch looks good, we'll just have to fix what seems to be an unrelated problem in CI.

Copy link
Contributor

CLI load time: 0:00.23
Pull Request HEAD: 5e54f7bf0bb156e12d574c2fca12d8dacf4b292f
Imports that take more than 0.1 s:
import time: self [us] | cumulative | imported package

@SamuelLarkin SamuelLarkin merged commit 181ba61 into main Jun 20, 2024
2 checks passed
@SamuelLarkin SamuelLarkin deleted the dev.sl/457_metadata.psv branch June 20, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test_utils creates metadata.psv/ in your working directory
2 participants