Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@shopify/eslint-plugin has security warnings, how to deal with them? #557

Closed
1 task done
martijnhartlief opened this issue Jun 21, 2022 · 4 comments
Closed
1 task done
Assignees
Labels

Comments

@martijnhartlief
Copy link

martijnhartlief commented Jun 21, 2022

We're trying to resolve some dependabot security warnings that come from eslint-config-hardcore, for example:
@graphql-tools/url-loader@6.10.1 > graphql-config > eslint-plugin-graphql > @shopify/eslint-plugin

Since eslint-plugin-graphql is being deprecated and there hasn't been movement in @shopify/eslint-plugin to replace the package, is there any way around this?

@EvgenyOrekhov
Copy link
Owner

You probably don't need to worry about GraphQL-related packages since GraphQL-related rules are not included in eslint-config-hardcore.

BTW here's a good relevant article by Dan Abramov: npm audit: Broken by Design.

Also, I'm thinking about removing @shopify/eslint-plugin since eslint-config-hardcore uses only a few rules from it, but @shopify/eslint-plugin pulls too many transient dependencies.

@martijnhartlief
Copy link
Author

You probably don't need to worry about GraphQL-related packages since GraphQL-related rules are not included in eslint-config-hardcore.

Alright, we'll ignore them for now.

Also, I'm thinking about removing @shopify/eslint-plugin since eslint-config-hardcore uses only a few rules from it, but @shopify/eslint-plugin pulls too many transient dependencies.

That sounds like a more maintainable way of handling dependencies indeed. As I see it, depending on another "bundeling package" makes your work way harder.

@EvgenyOrekhov
Copy link
Owner

They fixed it in @shopify/eslint-plugin@42.0.0.
Released in eslint-config-hardcore@24.8.1.

image

@martijnhartlief
Copy link
Author

Nice! 👍🏻

@EvgenyOrekhov EvgenyOrekhov self-assigned this Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants