Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eslint-plugin-graphql is deprecated #327

Closed
5 tasks
pmcelhaney opened this issue Mar 22, 2022 · 1 comment · Fixed by #340
Closed
5 tasks

eslint-plugin-graphql is deprecated #327

pmcelhaney opened this issue Mar 22, 2022 · 1 comment · Fixed by #340
Assignees

Comments

@pmcelhaney
Copy link

Overview

This is just a heads up that eslint-plugin-graphql is deprecated and they're recommending switching to graphql-eslint.

Motivation

What inspired this enhancement? What makes you think this should be included?

I found it out about it while tracing dependencies for a dependabot security alert (CVE-2022-0235).

Labels

  • Add the Type: Enhancement label to this issue.

Area

  • Add any relevant Area: <area> labels to this issue

Scope

  • Is this issue related to a specific package?

    • Tag it with the Package: <package_name> label.

Checklist

  • Please delete the labels section before submitting your issue
  • I have described this issue in a way that is actionable (if possible)
@Tom-Bonnike
Copy link

Tom-Bonnike commented May 9, 2022

👍 I was considering working on this during HackDays but I’ll probably be working on something else instead.

What first got me to look into this a few weeks ago was that I found out the rule that enforces fetching ids when available is not working right now, at least not on Shopify/web. Not fetching ids can cause a bunch of Apollo cache issues and as such I think it’s another good reason to switch over to graphql-eslint and their require-id-when-available rule ASAP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants