Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to specify custom suffix to versionLabel #31

Merged
merged 4 commits into from
Aug 4, 2021

Conversation

dbpatel219
Copy link
Contributor

Add a get/set for versionSuffix

Copy link
Member

@komu komu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for the PR!

I have a question to clarify, but otherwise I'm ready to merge this.

src/main/java/fi/evident/gradle/beanstalk/DeployTask.java Outdated Show resolved Hide resolved
@dbpatel219
Copy link
Contributor Author

@komu I went ahead and updated the PR to reflect what we had discussed in adding the suffix all the time.

@komu komu merged commit 7e37d89 into EvidentSolutions:master Aug 4, 2021
@komu
Copy link
Member

komu commented Aug 4, 2021

Thanks! I merged the PR and published 0.3.1 with this change.

@dbpatel219
Copy link
Contributor Author

@komu thanks for the merge!!! Any timeline on when you think it would be available on maven repository?

@komu
Copy link
Member

komu commented Aug 4, 2021

You mean the plugin repository? It should be there, that's what I meant by publishing.

Check out https://plugins.gradle.org/plugin/fi.evident.beanstalk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants