-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[remarkable2 support]: change event files based on rM version #32
Conversation
remarkable2 uses /dev/input/event1 (from /dev/input/event0) open_remote_device already allows changing the file path so this just pushes that option up to the command line arguments. Also move the logging setup before calling open_remote_device otherwise debug in that function doesn't work.
Why not just add a |
I thought of that but then when there's an rm3, or other device that uses the same digitiserthingie... I honestly have no real convictions either way. |
I think a more convenient solution would be to detect the current version of the hardware, and automatically read from the correct device. There might be a better way to do this, but I was thinking we could check the contents of |
I agree with this. I'd prefer to make the user experience seamless. Here is a relevant issue on Oxide: Eeems-Org/oxide#48 |
So it seems the best way to recognize which reMarkable one uses, according to the discussion here, is via |
imo, you should use ioctl to detect which device is the stylus.,see this gist from oxide thread this will be more future proof than picking based on current device name |
@raisjn The problem is that remouse runs entirely on the host, and I'm not sure if shipping an ARM binary for the ioctl probing is worth the added complexity of distributing, installing and executing the binary. |
ah, good point! shipping the arm binary is likely not worth it, i thought you are using libevdev but it's only on the host |
See the |
remarkable2 uses /dev/input/event1 (from /dev/input/event0)
open_remote_device already allows changing the file path so this just pushes that option up to the command line arguments.
Also move the logging setup before calling open_remote_device otherwise debug in that function doesn't work.