Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature - Fix rename apikey to usertoken in ReadMe #49

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

WouterHD
Copy link

@WouterHD WouterHD commented Nov 7, 2019

Usertoken was wrongfully referred to as APIKey in the ReadMe, which caused some confusion.

@WouterHD WouterHD force-pushed the feature/FixUsertokenNamingInReadMe branch from d3d761d to 80661f8 Compare November 7, 2019 16:38
@WouterHD WouterHD requested a review from MrJoe November 20, 2019 13:59
@WouterHD WouterHD added the waiting-for-final-review Passed by initial reviewers and waiting for a senior to accept the changes label Feb 18, 2020
Comment on lines -19 to +20
var client = new SignHostApiClient(new SignHostApiClientSettings("AppName appkey", "apikey or usertoken"));
var client = new SignHostApiClient(new SignHostApiClientSettings("AppName appkey", "usertoken"));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't do this as some existing customers only know the term apikey

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting-for-final-review Passed by initial reviewers and waiting for a senior to accept the changes
Development

Successfully merging this pull request may close these issues.

3 participants