Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TextSelection endpoint not pointing into a node with inline content (doc) warning #58

Open
swxk19 opened this issue Jun 19, 2022 · 3 comments
Open

TextSelection endpoint not pointing into a node with inline content (doc) warning #58

swxk19 opened this issue Jun 19, 2022 · 3 comments
Assignees
@EvitanRelta @swxk19
Labels
bug Something isn't working tiptap Related to TipTap editor

Comments

@swxk19
Copy link
Collaborator

swxk19 commented Jun 19, 2022 •
edited by EvitanRelta
Loading

TextSelection endpoint not pointing into a node with inline content (doc) error in the console:

image
@swxk19 swxk19 added the bug Something isn't working label Jun 19, 2022
@swxk19 swxk19 mentioned this issue Jun 19, 2022
Merged
@EvitanRelta
Copy link
Owner

Seems to be a bug on TipTap's side: ueberdosis/tiptap#2846

Which can be fix by restricting the Prosemirror packages' versions: ueberdosis/tiptap#2836 (comment)

swxk19 added a commit to swxk19/markgh that referenced this issue Jun 20, 2022
@swxk19
Fix for 'TextSelection' warning (Issue EvitanRelta#58)
b021ab5
swxk19 added a commit to swxk19/markgh that referenced this issue Jun 20, 2022
@swxk19
Fix 'TextSelection' warning in console (Issue EvitanRelta#58)
443c918
swxk19 added a commit to swxk19/markgh that referenced this issue Jun 20, 2022
@swxk19
Fix 'TextSelection' warning in console (Issue EvitanRelta#58)
51f765c
@swxk19 swxk19 mentioned this issue Jun 20, 2022
Merged
swxk19 added a commit to swxk19/markgh that referenced this issue Jun 20, 2022
@swxk19
Fix for 'TextSelection' warning (Issue EvitanRelta#58)
e5dfc50
@swxk19 swxk19 closed this as completed Jun 20, 2022
swxk19 added a commit to swxk19/markgh that referenced this issue Jun 21, 2022
@swxk19
Fix for 'TextSelection' warning (Issue EvitanRelta#58)
58a418b
swxk19 added a commit to swxk19/markgh that referenced this issue Jun 21, 2022
@swxk19
Fix for 'TextSelection' warning (Issue EvitanRelta#58)
563e630
swxk19 added a commit to swxk19/markgh that referenced this issue Jun 21, 2022
@swxk19
Fix for 'TextSelection' warning (Issue EvitanRelta#58)
41b95d3
@EvitanRelta EvitanRelta added this to the Orbital Milestone 2 milestone Jun 26, 2022
EvitanRelta added a commit that referenced this issue Jul 1, 2022
@EvitanRelta
Unlock fixed 'prosemirror' version in 'package.json'
0f3456e 
Reverts the version-locking of 'prosemirror' packages done in
commit 51f765c

This is required as new versions of TipTap will stop working if
the 'prosemirror' packages aren't updated.
And this also introduces bug #58 again.
EvitanRelta added a commit that referenced this issue Jul 1, 2022
@EvitanRelta
Merge branch 'fix-036-revert-temp-fix'
b8aef34 
Reverts the temp fix for #36 done in commit
cfb2ff8 as the fix
(ueberdosis/tiptap#2884) has been published in
'@tiptap/react' version 2.0.0-beta.114

Fixes #36
Reopens #58
@EvitanRelta
Copy link
Owner

Reintroduced by 0f3456e as the prosemirror packages had to be updated before updating TipTap.

@EvitanRelta EvitanRelta reopened this Jul 1, 2022
EvitanRelta added a commit that referenced this issue Jul 12, 2022
@EvitanRelta
Update TipTap packages
3238dec 
Fixes partially #58, from the recent ueberdosis/tiptap#2934 PR fix that
has been published in '@tiptap/core@2.0.0-beta.182'.
@EvitanRelta EvitanRelta removed this from the Orbital Milestone 2 milestone Jul 12, 2022
@EvitanRelta EvitanRelta changed the title Console gives warning when fetching persisted text TextSelection endpoint not pointing into a node with inline content (doc) warning Jul 13, 2022
@EvitanRelta
Copy link
Owner

After 3238dec (which brings in a fix for this: ueberdosis/tiptap#2934), it now doesn't print this warning during startup anymore.

However, it still prints this warning when inserting a horizontal-rule, likely because its not been fixed on the @tiptap/extension-horizontal-rule extension.

@EvitanRelta EvitanRelta self-assigned this Jul 13, 2022
@EvitanRelta EvitanRelta added the tiptap Related to TipTap editor label Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EvitanRelta EvitanRelta

@swxk19 swxk19

Labels
bug Something isn't working tiptap Related to TipTap editor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@EvitanRelta @swxk19