clean: docker network declaration and build of the evolution/api
image
#78
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SH code to check existence of unnecessary docker network.
It is only for using an existing main network.
Since the
docker-compose*.yml
files are already primarily responsible for provisioning the main application stack, it doesn't make sense to create the network in a task outside its scope.This is just a small contribution from someone who has just arrived and is already impressed with this community!
The docker build command will be removed in future releases in favor of buildx.
The Dockerfile build can be done by
docker-compose*.yml
itself by adding thebuild: .
property in the api service.