Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean: docker network declaration and build of the evolution/api image #78

Merged
merged 3 commits into from
Aug 29, 2023
Merged

clean: docker network declaration and build of the evolution/api image #78

merged 3 commits into from
Aug 29, 2023

Conversation

AdsonCicilioti
Copy link
Contributor

@AdsonCicilioti AdsonCicilioti commented Aug 26, 2023

SH code to check existence of unnecessary docker network.

   external: true

It is only for using an existing main network.
Since the docker-compose*.yml files are already primarily responsible for provisioning the main application stack, it doesn't make sense to create the network in a task outside its scope.

This is just a small contribution from someone who has just arrived and is already impressed with this community!

The docker build command will be removed in future releases in favor of buildx.
The Dockerfile build can be done by docker-compose*.yml itself by adding the build: . property in the api service.

@AdsonCicilioti AdsonCicilioti changed the title clean: declarative bridge network instead shellscript check clean: docker network declaration and build of the evolution/api image Aug 26, 2023
@DavidsonGomes DavidsonGomes merged commit 7ade78b into EvolutionAPI:main Aug 29, 2023
@AdsonCicilioti
Copy link
Contributor Author

@DavidsonGomes if the instruction to use the ./docker.sh file exists somewhere in the documentation, you will have to update to just use docker compose up -d.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants