[feat] changes on llava_vid model #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kcz358
reviewed
Oct 3, 2024
kcz358
reviewed
Oct 3, 2024
lmms_eval/models/llava_vid.py
Outdated
| elif self.torch_dtype == "bfloat16": | ||
| video = video.bfloat16() | ||
| else: | ||
| import pdb;pdb.set_trace() |
There was a problem hiding this comment.
Can replace it with an error message or log warning message
kcz358
reviewed
Oct 3, 2024
kcz358
reviewed
Oct 3, 2024
kcz358
reviewed
Oct 3, 2024
kcz358
reviewed
Oct 3, 2024
kcz358
reviewed
Oct 3, 2024
lmms_eval/models/srt_api.py
Outdated
Comment on lines
230
to
232
| if doc_id != 7: | ||
| response = "A" | ||
| return response |
There was a problem hiding this comment.
Is this hardcoded? Looks like you need to remove this to output correctly
kcz358
reviewed
Oct 3, 2024
kcz358
reviewed
Oct 3, 2024
kcz358
reviewed
Oct 3, 2024
kcz358
reviewed
Oct 3, 2024
kcz358
reviewed
Oct 3, 2024
Luodian
changed the title
kcz358
approved these changes
Oct 13, 2024
KairuiHu
pushed a commit
that referenced
this pull request
Oct 24, 2024
* Update gitignore and videomme tasks configuration files * Fix prompt post_prompt in videomme.yaml and videomme_w_subtitle.yaml * Fix inconsistent indentation in utils.py
ZhaoCinyu
pushed a commit
to ZhaoCinyu/lmms-eval
that referenced
this pull request
Dec 9, 2024
* Update gitignore and videomme tasks configuration files * Fix prompt post_prompt in videomme.yaml and videomme_w_subtitle.yaml * Fix inconsistent indentation in utils.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before you open a pull-request, please check if a similar issue already exists or has been closed before.
When you open a pull-request, please be sure to include the following
Thank you for your contributions!