fix: add max_frames_num to OpenAICompatible

[loongfeili]

The openai_compatible implementation requires the self.max_frames_num attribute for video input processing, as seen in this line. However, this attribute was missing in the OpenAICompatible class. This PR adds the missing max_frames_num attribute to resolve the issue.

Summary by CodeRabbit

• New Features
  • Introduced a new optional setting to control the maximum number of frames, with a default value of 10, for improved customization.

[coderabbitai]

Walkthrough

The constructor of the OpenAICompatible class was updated to include a new optional parameter, max_frames_num, defaulting to 10. This value is saved as an instance attribute. No other logic or method in the class was modified.

Changes

File	Change Summary
lmms_eval/models/openai_compatible.py	Added max_frames_num parameter (default 10) to OpenAICompatible constructor and stored as attribute.

Poem

A tweak to the code, a hop in the frame,
Now max_frames_num has entered the game.
Ten is its number, by default it will be,
Stored in the class for all to see.
🐇✨ Code grows as rabbits do—quietly!

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8ada805 and b068e06.

📒 Files selected for processing (1)

• lmms_eval/models/openai_compatible.py (2 hunks)

🔇 Additional comments (2)

lmms_eval/models/openai_compatible.py (2)

41-41: LGTM: Parameter addition is well-implemented.

The addition of max_frames_num: int = 10 parameter is correctly positioned in the constructor signature with proper type annotation and a reasonable default value for video frame sampling.

---

50-50: LGTM: Instance attribute assignment is correct.

The self.max_frames_num = max_frames_num assignment properly stores the parameter as an instance attribute, which is used later in the encode_video method call on line 167. This fixes the missing attribute issue mentioned in the PR objectives.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.