easier code for multiple images #879
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kcz358
reviewed
Nov 3, 2025
Collaborator
There was a problem hiding this comment.
This extra line should be removed
kcz358
reviewed
Nov 3, 2025
Comment on lines
+32
to
+43
| def hb_doc_to_visual(doc): | ||
| """Convert document to visual input.""" | ||
| num_image = int(os.environ.get("NUM_IMAGE", "1")) | ||
|
|
||
| if num_image == 1: | ||
| # print("one image!") | ||
| return [doc["image"].convert("RGB")] | ||
| elif num_image == 2: | ||
| # print("two images!") | ||
| return [doc["image"].convert("RGB"), doc["image"].convert("RGB")] | ||
| else: | ||
| raise ValueError(f"num_image must be 1 or 2, got {num_image}") |
Collaborator
There was a problem hiding this comment.
May I ask is the replicated images necessary for evaluating hallusionbench?
kcz358
reviewed
Nov 3, 2025
Collaborator
kcz358
left a comment
kcz358
left a comment
There was a problem hiding this comment.
Hi, thank you for your contribution! I've seen that you are added some image first options in simple models such as llava ov and vllm. Though the changes are acceptable, you are more recommended to create a doc_to_messages and use the chat model for auto formatting.
Another question is that I have seen you are replicate images for many benchmarks. May I ask what are these used for?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before you open a pull-request, please check if a similar issue already exists or has been closed before.
When you open a pull-request, please be sure to include the following
If you meet the lint warnings, you can use following scripts to reformat code.
Thank you for your contributions!