-
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*BREAKING CHANGE* Improve Watermark with colors, rotation and other settings #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Improved readability by inserting line breaks in properties for clarity. Enhanced functionality of WordHeaderFooter by introducing a Watermarks property, retrieving watermarks from either header or footer sections as applicable. This change streamlines watermark access, facilitating document manipulation tasks.
Introduced a new property to list all watermarks across the document's sections. This update simplifies access to watermarks for users seeking to analyze or modify them without iterating over each section manually. The enhancement boosts code readability and efficiency when working with documents containing multiple watermarks.
Refactored WordSection class to include XML summary comments for public properties, improving code documentation and developer experience. Removed unused using directives and legacy commented-out code, resulting in cleaner and more readable sources. The changes enhance code maintainability by providing clear descriptions of properties for paragraphs, page breaks, lists, embedded documents, and watermarks.
Enhanced document processing capabilities by adding a method for transforming standardized blocks into watermark objects, supporting richer content handling in documents. Concurrently, deprecated an unused paragraph conversion method to improve maintainability without impacting functionality—preparing for future removal if confirmed unnecessary.
Closed
Implemented new internal utility methods for document element conversions such as converting tables to WordTables, SdtBlocks to WordWatermarks, and paragraphs to WordParagraphs. Enhanced the section data retrieval by adding methods to get the list of paragraphs and SdtBlocks within sections. These changes provide a structured way to manipulate document elements and improve the ease of document section data access in preparation for future document manipulation features. Refactors ensure consistency and extend our library's functionality, potentially improving performance and maintainability. The introduced conversion methods prepare the groundwork for upcoming features that require more granular control over document elements.
Removed unnecessary comment clutter around the watermark rotation parsing logic, streamlining code readability. Introduced a new constructor that allows adding text watermarks to sections with or without existing paragraphs, enhancing versatility. Additionally, implemented a Remove method to facilitate watermark deletion, improving object manageability. These enhancements ensure that watermarks can be easily added or removed, catering to more dynamic document manipulation requirements.
Refactored parsing of watermark width and height properties to correctly interpret the numerical values in an invariant culture context. This change prevents potential issues with locale-specific decimal separators, guaranteeing that the watermark dimensions are consistent regardless of the user's regional settings. Fixes potential bugs with international usage where '.' is not the decimal separator.
PrzemyslawKlys
changed the title
Improve Watermark with colors, rotation and other settings
*BREAKING CHANGE* Improve Watermark with colors, rotation and other settings
Dec 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves:
This change adds:
Breaking changes
This example shows per section in header:
This example shows per page: