WIP: refactoring of mesh representation #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I now evaluate the nodes in the poloidal plane eagerly (but the 3D field traces will still be done lazily). I have refactored mesh.py, hypnotoad_interface.py, nektar_writer.py, meshio_writer.py, and wall.py to use this new approach. Everything else has just had some renaming done and won't actually run. None of the tests have been refactored yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to eager evaluation of control points/nodes in the poloidal plane. This will avoid duplicating work which was otherwise happening. It also means that the selection of intermediate points can now be handled by Hypnotoad and that Hypnotoad's non-orthogonal meshes can be used. 3D field traces will still be done lazily.