[EXILED::API]
Fixing NPC PlayerId assignment
#135
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes
What is the current behavior? (You can also link to an open issue here)
Currently when creating an NPC an Id is assigned by RecyclablePlayerId and checking if it is in use, this should not be done since when creating a ReferenceHub in the Awake method this already assigns an available ID, which currently causes that we leave an ID permanently created and never destroyed leading to another player can use it and that there are 2 players with the same ID.
What is the new behavior? (if this is a feature change)
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information:
Testing
I tested the changes by making every time I jumped an NPC I played a sound to check if the ReferenceHub.OnDestroy is correctly running and it was possible to use it again without another player/npc taking the same id.
ReferenceHub.OnDestroy
Types of changes
Submission checklist
Patches (if there are any changes related to Harmony patches)
Other