Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JailBirdHitReg Fix #165

Merged
merged 2 commits into from
Nov 5, 2024
Merged

Conversation

NotZer0Two
Copy link

Description

Describe the changes
Based on the issue 479 of NW Report, i added a patch to fix the issue

What is the current behavior? (You can also link to an open issue here)
Kicks players out

What is the new behavior? (if this is a feature change)
Prevents this

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No

Other information:
Patch originally done by <@843246137938673695> (BanalnyBanan) on discord but never posted by his own investigation and mine, i found out the issue and fixed it based on his transpiler


Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentations

Submission checklist

  • I have checked the project can be compiled
  • I have tested my changes and it worked as expected

Patches (if there are any changes related to Harmony patches)

  • I have checked no IL patching errors in the console

Other

  • Still requires more testing

@VALERA771
Copy link

Change base branch to dev and... can you basically test it? (just hit glass with jailbrid)

@VALERA771 VALERA771 changed the base branch from master to dev November 5, 2024 18:26
@NotZer0Two
Copy link
Author

Change base branch to dev and... can you basically test it? (just hit glass with jailbrid)

Before i did the release i tested it with the glass and it did work fine, only i cannot test it with multiple people so that's why i set it to needs more testing

@VALERA771 VALERA771 merged commit 9cd0e45 into ExMod-Team:dev Nov 5, 2024
5 checks passed
VALERA771 added a commit that referenced this pull request Nov 5, 2024
Co-authored-by: ZeroTwo <63092138+NotZer0Two@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants