docs: better grammar and spelling #187
Conversation
"Whether or not" is incorrect, even though it is understandable, the language is incorrect and can just be whether, as whether infers there is a negative and a positive, https://english.stackexchange.com/questions/3382/whether-or-not-vs-whether. In the case of this, "or not" in "Whether or not" is not needed, as it is always undetermined the response in the documentation, the documentation won't know.
Can remove the "or not" when there is a whether in there
|
Maybe, maybe not, but it's correct English and if it's not wanted then fine, I just thought I would help out. I have some more changes I want to make too but not like this, just general documentation changes where clarification is needed |
|
I always thought Stylecop made it whether or not. |
|
I would hope not, but I got no stylecop related errors so |
|
Can you try compiling project on release? If you have already done it then put a tick in description |
Dev CI builds in release mode |
I honestly thought the same so that weird i would have expected error. |
Let me try now |
|
Only error I get is I don't think it has any relevance though, everything else passed |
I think they changed it recently and decided to remove the or not part. |
Description
Here all I do is change some minor things like the documentation where the English used is incorrect or just has spelling mistakes.
What is the current behavior? (You can also link to an open issue here)
No behaviour
What is the new behavior? (if this is a feature change)
No behaviour
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No
Other information:
Types of changes
Submission checklist
Patches (if there are any changes related to Harmony patches)
Other