Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RoleExtensions.IsMilitary to reflect how the wiki categorizes guards #188

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

Mikihero
Copy link

@Mikihero Mikihero commented Nov 20, 2024

Description

Describe the changes
RoleExtensions.IsMilitary() returns true for guards, this is because the official wiki classifies them as militant classes
image
image
https://en.scpslgame.com/index.php?title=Humans
https://en.scpslgame.com/index.php?title=Facility_Guard

What is the current behavior? (You can also link to an open issue here)
RoleExtensions.IsMilitary() returns false for guards

What is the new behavior? (if this is a feature change)
RoleExtensions.IsMilitary() returns true for guards as well

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Other information:


Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentations

Submission checklist

  • I have checked the project can be compiled
  • I have tested my changes and it worked as expected

Patches (if there are any changes related to Harmony patches)

  • I have checked no IL patching errors in the console

Other

  • Still requires more testing

@Misaka-ZeroTwo
Copy link
Collaborator

ummm this is also a breaking change

@Mikihero
Copy link
Author

ummm this is also a breaking change

it's a correction of #177 which was just merged to dev

@Misaka-ZeroTwo
Copy link
Collaborator

ummm this is also a breaking change

it's a correction of #177 which was just merged to dev

oh nvm then

@Misaka-ZeroTwo Misaka-ZeroTwo merged commit 07655b4 into ExMod-Team:dev Nov 22, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants