Scp1344Item & move Prefabs #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
build error moment |
forgot to commit ooops |
VALERA771
approved these changes
Nov 28, 2024
VALERA771
reviewed
Nov 28, 2024
| /// <param name="scale">The scale of the <see cref="Speaker"/>.</param> | ||
| /// <param name="spawn">Whether the <see cref="Speaker"/> should be initially spawned.</param> | ||
| /// <returns>The new <see cref="Speaker"/>.</returns> | ||
| public static Speaker Create(Vector3? position, Vector3? rotation, Vector3? scale, bool spawn) |
There was a problem hiding this comment.
if you consider them as nullable maybe add a null default value?
There was a problem hiding this comment.
we can add default value yeah, i just copied the method from another toy
|
Don't merge this pr for the moment because there is a problem with the prefab loader. We actually load them from NetworkClient which doesn't register prefabs before map generation so actually if we push this, we're unable to spawn things that use prefab when the map is generated |
louis1706
approved these changes
Nov 30, 2024
BoltonDev
approved these changes
Nov 30, 2024
|
There are conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes
What is the current behavior? (You can also link to an open issue here)
What is the new behavior? (if this is a feature change)
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information:
Types of changes
Submission checklist
Patches (if there are any changes related to Harmony patches)
Other