-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New NPC Api #241
New NPC Api #241
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
might also wanna fix all the shit stylecops asking about
i honestly don't know, how to do it because most of the stuff is impossible to do it being something on the game not possible to cache |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have had internal discussions about npcs in Player.List
and came to decision that list shouldn't contain them. Can you do a separate list for npc in its class and remove them from list in player's class?
I wanted to ask that but figure it out on just doing the fixes and nothing else and yes i will do a dictionary that is not included |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We still can use same player's class dictionary but just remove npc from List in player's class
Like what i showed and merged on the pr? |
OH I understand |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make it IReadonlyCollection and it'll be perfect
Done. |
Description
Describe the changes
Changes the entire NPC Api to use the dummies and adds the new follow system for dummies
What is the current behavior? (You can also link to an open issue here)
None
What is the new behavior? (if this is a feature change)
None
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Yes some method in specific Spawn() Used to have the InstanceId but now removed.
Other information:
Introduces a new way and actually vsr friendly to the npcs, removing the old system without alot of changes
Types of changes
Submission checklist
Patches (if there are any changes related to Harmony patches)
Other