-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Respawn API changes #246
Respawn API changes #246
Conversation
a lot of this is adapted from |
there are 100% some things I shouldn't have done or should've done differently but I'm too tired to go through them myself, @Misaka-ZeroTwo @Misfiy if you could take another look and point everything out that'd be great |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can argue with me about this comments but imho this is just better
Co-authored-by: VALERA771 <72030575+VALERA771@users.noreply.github.com>
agree on all of those lmao |
@VALERA771 do you think I should add more overloads to methods like |
I'm too tired too think clearly rn, someone tell me if I overcooked with this last addition |
Start writing docs pls. And what overloads on spawning method you want to add? |
I'll get a good chunks of the docs done today. I was talking about methods like |
pls tell me if I've missed something |
You've missed writing docs 😄 |
wait I forgot docs for rolextensions |
I don't think that we need so many seealso on overloads |
I guess that makes sense, I'll just add 1 for different (but similar) methods instead of for every overload |
Timer methods have too much seealso xml docs |
Description
Describe the changes
Added and changed some parts of the respawn api to reflect new changes, not done by any means
What is the current behavior? (You can also link to an open issue here)
What is the new behavior? (if this is a feature change)
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information:
Types of changes
Submission checklist
Patches (if there are any changes related to Harmony patches)
Other