Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: microhid events #339

Merged
merged 3 commits into from
Dec 26, 2024
Merged

fix: microhid events #339

merged 3 commits into from
Dec 26, 2024

Conversation

IRacle1
Copy link

@IRacle1 IRacle1 commented Dec 24, 2024

Description

Describe the changes
It turns out that microhid state changes can now happen independent from player, like when microhid is pickup
So:

  • Optimized ChangingMicroHIDStateEventArgs to not get item by serial(and iterating all items😅).
  • Added ChangingMicroHIDPickupStateEventArgs (in Item namespace)

What is the current behavior? (You can also link to an open issue here)
Above

What is the new behavior? (if this is a feature change)
Above

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No💔

Other information:


Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentations

Submission checklist

  • I have checked the project can be compiled
  • I have tested my changes and it worked as expected

Patches (if there are any changes related to Harmony patches)

  • I have checked no IL patching errors in the console

Other

  • Still requires more testing

@IRacle1 IRacle1 changed the title feat/fix: microhid events fix: microhid events Dec 24, 2024
@louis1706 louis1706 merged commit f68e1b3 into ExMod-Team:dev Dec 26, 2024
6 checks passed
@IRacle1 IRacle1 deleted the another4 branch December 26, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants