Skip to content

Conversation

@skyfr0676
Copy link

@skyfr0676 skyfr0676 commented Dec 31, 2024

Description

Describe the changes: add the DisruptorFiring event on the Item handler

What is the new behavior? Actually the particle disruptor still shoot even if we drop the item. So this event is called for this. Added from https://discord.com/channels/656673194693885975/663978314683252777/1322013909972156496

Does this PR introduce a breaking change? No


Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentations

Submission checklist

  • I have checked the project can be compiled
  • I have tested my changes and it worked as expected.

Patches (if there are any changes related to Harmony patches)

  • I have checked no IL patching errors in the console

Other

  • Still requires more testing

@skyfr0676
Copy link
Author

i still don't know how to block audio T_T

@louis1706 louis1706 marked this pull request as draft January 10, 2025 21:15
@louis1706
Copy link

i put it as Draft since you don't want it to be merged now

@skyfr0676 skyfr0676 marked this pull request as ready for review January 13, 2025 21:34
@skyfr0676 skyfr0676 changed the title feat: DisruptorFiring event addition [DONT MERGE] feat: DisruptorFiring event addition Jan 13, 2025
@VALERA771 VALERA771 requested a review from obvEve February 24, 2025 06:36
@louis1706 louis1706 merged commit d43fc36 into ExMod-Team:dev Apr 20, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants