Skip to content

Conversation

@LumiFae
Copy link

@LumiFae LumiFae commented Jan 15, 2025

Description

Adds a new Speaker instantiate method that allows you to bind with a transform

What is the current behavior? (You can also link to an open issue here)
Right now, you can only spawn based on a position, not a transform, so you can't stick it to the transform.

What is the new behavior? (if this is a feature change)
Allows you to create a Speaker based on a transform


Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentations

Submission checklist

  • I have checked the project can be compiled
  • I have tested my changes and it worked as expected

Patches (if there are any changes related to Harmony patches)

  • I have checked no IL patching errors in the console

Other

  • Still requires more testing

@github-actions github-actions bot added the API label Jan 15, 2025
@LumiFae LumiFae changed the title feat: add transform create feat(Speaker): add transform create Jan 15, 2025
Copy link
Member

@obvEve obvEve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesnt seem needed imo

@LumiFae
Copy link
Author

LumiFae commented Feb 5, 2025

doesnt seem needed imo

People want to bind speakers to a transform, like for me I did Speaker.Create() based on a transform and then just parented the speaker with the transform, but this solution is cleaner imo

@louis1706
Copy link

doesnt seem needed imo

i did need it in one of my plugin lol so yeah it's needed

@louis1706 louis1706 merged commit cbb7494 into ExMod-Team:dev Apr 21, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants