Skip to content

fix: Room::NearestRooms fix #417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
louis1706 merged 1 commit into from
Jan 30, 2025
Merged

fix: Room::NearestRooms fix #417

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions EXILED/Exiled.API/Features/Room.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,16 @@ public class Room : MonoBehaviour, IWorldSpace
/// <summary>
/// Gets a <see cref="IReadOnlyList{T}"/> of <see cref="Room"/> around the <see cref="Room"/>.
/// </summary>
public IReadOnlyList<Room> NearestRooms { get; private set; }
public IReadOnlyList<Room> NearestRooms
{
get
{
if (NearestRoomsValue.Count == 0 && Identifier.ConnectedRooms.Count > 0)
NearestRoomsValue.AddRange(Identifier.ConnectedRooms.Select(Get));

return NearestRoomsValue;
}
}

/// <summary>
/// Gets a <see cref="IEnumerable{T}"/> of <see cref="Pickup"/> in the <see cref="Room"/>.
Expand Down Expand Up @@ -438,7 +447,6 @@ internal void InternalCreate()

Windows = WindowsValue.AsReadOnly();
Doors = DoorsValue.AsReadOnly();
NearestRooms = NearestRoomsValue.AsReadOnly();
Speakers = SpeakersValue.AsReadOnly();
Cameras = CamerasValue.AsReadOnly();
}
Expand Down
1 change: 0 additions & 1 deletion EXILED/Exiled.Events/Patches/Generic/DoorList.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,6 @@ private static void InitDoor(DoorVariant doorVariant)
foreach (Room room in rooms)
{
room.DoorsValue.Add(door);
room.NearestRoomsValue.AddRange(rooms.Except(new List<Room>() { room }));
}

if (door.Is(out CheckpointDoor checkpoint))
Expand Down
Loading