fix: fixed npc health #420
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
VALERA771
reviewed
Feb 3, 2025
VALERA771
left a comment
VALERA771
left a comment
There was a problem hiding this comment.
I hope that nothing will be broken
Co-authored-by: VALERA771 <72030575+VALERA771@users.noreply.github.com>
VALERA771
approved these changes
Feb 6, 2025
obvEve
requested changes
Feb 6, 2025
EXILED/Exiled.Events/Patches/Events/Map/ExplodingFlashGrenade.cs
Outdated
Show resolved
Hide resolved
Author
|
@Misfiy |
|
I think some conditions in flashbang are wrong. Can you check if all good? |
louis1706
reviewed
Feb 24, 2025
louis1706
approved these changes
Apr 2, 2025
louis1706
approved these changes
Apr 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes
https://discord.com/channels/656673194693885975/1300857604620161064
NPC's health works correctly.
Custom role is removed even if it's the same roletype.
What is the current behavior? (You can also link to an open issue here)
NPC's health was always at 0, the custom health stat did nothing.
Custom role wasn't updated when a custom role A with a role was given to a player that already had custom role B with same role.
What is the new behavior? (if this is a feature change)
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Yes.
HumeShieldStat is now obsolete.
Other information:
Types of changes
Submission checklist
Patches (if there are any changes related to Harmony patches)
Other