Skip to content

Conversation

@Num10ck
Copy link

@Num10ck Num10ck commented Feb 13, 2025

Description

Describe the changes
Added a method Exiled.API.Features.Map.Clean designed to cleanup specified Decals.DecalPoolType.

What is the current behavior? (You can also link to an open issue here)
There are no methods (or these method not in Exiled.API.Features.Map) for cleaning up decals.

What is the new behavior? (if this is a feature change)

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
This PR introduces only methods and using directives.

Other information:
Probably not cleaning the glass (DecalPoolType.GlassCrack) (at least in the SCP-330 chamber).


Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentations

Submission checklist

  • I have checked the project can be compiled
  • I have tested my changes and it worked as expected

Patches (if there are any changes related to Harmony patches)

  • I have checked no IL patching errors in the console

Other

  • Still requires more testing

@github-actions github-actions bot added the API label Feb 13, 2025
@Num10ck Num10ck changed the title Added method Exiled.API.Features.Map.Clean feat: Added method Exiled.API.Features.Map.Clean Feb 13, 2025
Num10ck and others added 2 commits February 14, 2025 05:40
Co-authored-by: Yamato <66829532+louis1706@users.noreply.github.com>
Co-authored-by: Yamato <66829532+louis1706@users.noreply.github.com>
@Num10ck
Copy link
Author

Num10ck commented Feb 14, 2025

Also I think it would be useful to copy DecalPoolType to new enum with FlagsAttribute and rename this method to CleanDecals

@github-actions github-actions bot added Transpiler base-game-bug Bug from the main game labels Feb 14, 2025
@Num10ck
Copy link
Author

Num10ck commented Feb 14, 2025

It looks like I accidentally committed a fix for the RA command in this PR

@louis1706
Copy link

It looks like I accidentally committed a fix for the RA command in this PR

so what will you do ?

@Num10ck
Copy link
Author

Num10ck commented Feb 17, 2025

It looks like I accidentally committed a fix for the RA command in this PR

so what will you do ?

Idk what to do. This is my first PR.

@Num10ck
Copy link
Author

Num10ck commented Feb 17, 2025

I have to somehow exclude the last two commits from here

@Num10ck
Copy link
Author

Num10ck commented Feb 18, 2025

Is there anything else I need to do in this PR?

@VALERA771 VALERA771 merged commit 9be51ad into ExMod-Team:dev Feb 18, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API base-game-bug Bug from the main game

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants