Skip to content

Conversation

@R2kip
Copy link

@R2kip R2kip commented Feb 22, 2025

Description

Describe the changes
When IsAllowed = false, a start sound was produced, which should not be there.
I changed the event call location from IntercomState.Starting to IntercomState.Ready after receiving the ReferenceHub

What is the current behavior? (You can also link to an open issue here)

What is the new behavior? (if this is a feature change)

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Highly unlikely.

Other information:


Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentations

Submission checklist

  • I have checked the project can be compiled
  • I have tested my changes and it worked as expected

Patches (if there are any changes related to Harmony patches)

  • I have checked no IL patching errors in the console

Other

  • Still requires more testing

@R2kip R2kip changed the base branch from master to dev February 22, 2025 01:36
@louis1706 louis1706 merged commit 8485d8f into ExMod-Team:dev Feb 25, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants