Skip to content

fix: Fix ci locker spawns #450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
VALERA771 merged 7 commits into from
Mar 10, 2025
Merged

fix: Fix ci locker spawns #450

VALERA771 merged 7 commits into from
Mar 10, 2025

Conversation

@obvEve
Copy link
Member

@obvEve obvEve commented Feb 27, 2025

No description provided.

@obvEve obvEve changed the base branch from master to dev February 27, 2025 19:25
@obvEve obvEve self-assigned this Feb 27, 2025
@obvEve obvEve added the bug Something isn't working label Feb 27, 2025
@obvEve
Copy link
Member Author

obvEve commented Feb 28, 2025

Dont merge yet

@obvEve
Copy link
Member Author

obvEve commented Feb 28, 2025

Isnt confirmed as fixed

@louis1706 louis1706 added the Do not merge Don't merge this PR label Feb 28, 2025
@obvEve obvEve requested a review from VALERA771 March 2, 2025 19:00
@obvEve
Copy link
Member Author

obvEve commented Mar 2, 2025 •
edited
Loading

half the issue is fixed
but the item is still not pickupable 🤷‍♀️

@VALERA771
Copy link

VALERA771 commented Mar 2, 2025

Isn't that the issue which you're fixing?

@obvEve
Copy link
Member Author

obvEve commented Mar 2, 2025

Isn't that the issue which you're fixing?

I fixed CI being part of the wrong locker (could be a locker in Heavy, even if the item was in Light)
I just fixed CI not being considered CI when spawned in a locker spawnpoint

Now I need to fix locked issue

@obvEve
Copy link
Member Author

obvEve commented Mar 2, 2025

okay works for me now (both with and without UseChamber)

@obvEve obvEve added enhancement New feature or request and removed Do not merge Don't merge this PR labels Mar 2, 2025
@VALERA771 VALERA771 merged commit 6b77fa5 into ExMod-Team:dev Mar 10, 2025
6 checks passed
@dependabot dependabot bot mentioned this pull request Aug 5, 2025
Open
@dependabot dependabot bot mentioned this pull request Aug 26, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@louis1706 louis1706 louis1706 approved these changes

@VALERA771 VALERA771 VALERA771 approved these changes

Assignees

@obvEve obvEve

Labels

API bug Something isn't working CustomModules enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@obvEve @VALERA771 @louis1706