Skip to content

Conversation

@SnivyFilms
Copy link

Description

Describe the changes
Changes "return if the effect has been Enable." to "A bool indicating whether the effect was valid and successfully enabled." as the former made no grammatical sense.

What is the current behavior? (You can also link to an open issue here)
It makes no grammatical sense
https://discord.com/channels/656673194693885975/1350404844292411405/1350404844292411405

What is the new behavior? (if this is a feature change)
It makes grammatical sense, using the same return as the other EnableEffects returns.

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Other information:
Made it target the correct branch by the request from Yamato
https://discord.com/channels/656673194693885975/1350404844292411405/1350467375329447946


Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentations

Submission checklist

  • I have checked the project can be compiled
  • I have tested my changes and it worked as expected

Patches (if there are any changes related to Harmony patches)

  • I have checked no IL patching errors in the console

Other

  • Still requires more testing

@louis1706 louis1706 merged commit 5d0817f into ExMod-Team:master Mar 15, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants