Skip to content

Conversation

@MS-crew
Copy link

@MS-crew MS-crew commented Apr 12, 2025

Description

Describe the changes
Removed the incorrect and unused IsAllowed argument from the Scp1344.ChangedStatus event.
Refactored the ChangingStatus (prefix) and ChangedStatus (postfix) patches into a unified transpiler implementation.

What is the current behavior? (You can also link to an open issue here)
The ChangedStatus event incorrectly includes an IsAllowed argument, which is not used and may cause confusion.
Event hooks are separated and not streamlined within a single transpiler.

What is the new behavior? (if this is a feature change)
Events are now handled within a single, unified transpiler for better clarity and control.
The ChangedStatus event has been cleaned up to include only relevant data.

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No

Other information:
This cleanup improves maintainability and reduces redundancy in the event patching system for SCP-1344 status changes.


Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentations

Submission checklist

  • I have checked the project can be compiled
  • I have tested my changes and it worked as expected

Patches (if there are any changes related to Harmony patches)

  • I have checked no IL patching errors in the console

Other

  • Still requires more testing

@MS-crew MS-crew requested a review from louis1706 April 13, 2025 13:03
@MS-crew MS-crew requested a review from louis1706 April 14, 2025 17:59
Copy link

@louis1706 louis1706 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will just required small change than i will done this night (if not ping me tomorrow)

@MS-crew
Copy link
Author

MS-crew commented Apr 20, 2025

@louis1706 hello master Ping time DING DONGGG

@VALERA771 VALERA771 merged commit ab17235 into ExMod-Team:dev Apr 21, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants