forked from Exiled-Official/EXILED
-
Notifications
You must be signed in to change notification settings - Fork 105
feat: Fix wrong arg & Scp1344 Status change Prefix/Postfix to Transpiler #486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louis1706
requested changes
Apr 13, 2025
louis1706
requested changes
Apr 14, 2025
louis1706
reviewed
Apr 14, 2025
EXILED/Exiled.Events/EventArgs/Scp1344/ChangedStatusEventArgs.cs
Outdated
Show resolved
Hide resolved
louis1706
approved these changes
Apr 19, 2025
louis1706
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will just required small change than i will done this night (if not ping me tomorrow)
Author
|
@louis1706 hello master Ping time DING DONGGG |
louis1706
approved these changes
Apr 20, 2025
VALERA771
approved these changes
Apr 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes
Removed the incorrect and unused IsAllowed argument from the Scp1344.ChangedStatus event.
Refactored the ChangingStatus (prefix) and ChangedStatus (postfix) patches into a unified transpiler implementation.
What is the current behavior? (You can also link to an open issue here)
The ChangedStatus event incorrectly includes an IsAllowed argument, which is not used and may cause confusion.
Event hooks are separated and not streamlined within a single transpiler.
What is the new behavior? (if this is a feature change)
Events are now handled within a single, unified transpiler for better clarity and control.
The ChangedStatus event has been cleaned up to include only relevant data.
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No
Other information:
This cleanup improves maintainability and reduces redundancy in the event patching system for SCP-1344 status changes.
Types of changes
Submission checklist
Patches (if there are any changes related to Harmony patches)
Other