Skip to content

Conversation

@mawosl
Copy link

@mawosl mawosl commented Apr 13, 2025

Description

Describe the changes
New event for when SCP049-2 performs an attack (if hits target or not)

What is the current behavior? (You can also link to an open issue here)
None

What is the new behavior? (if this is a feature change)
New Event

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No

Other information:


Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentations

Submission checklist

  • I have checked the project can be compiled
  • I have tested my changes and it worked as expected

Patches (if there are any changes related to Harmony patches)

  • I have checked no IL patching errors in the console

Other

  • Still requires more testing

@mawosl mawosl changed the title 049-2 HitEvents feat: 049-2 HitEvents Apr 13, 2025
@louis1706
Copy link

Can you verify than 939 don't trigger this event please

@mawosl
Copy link
Author

mawosl commented Apr 14, 2025

939 does not trigger event now

@MS-crew
Copy link

MS-crew commented Apr 16, 2025

in transpiler why create a local variable that you never use and copy the eventargument and assign it to it. if you never use it, you can remove it

@mawosl
Copy link
Author

mawosl commented Apr 16, 2025

removed unnecessary lines from transpiler (thanks @MS-crew :>)

@louis1706
Copy link

I still don't get why you make it only for Scp049-2 where you could have done it for all Scp with this AttackAbility

@mawosl mawosl changed the title feat: 049-2 HitEvents feat: HitEvents Apr 18, 2025
@mawosl mawosl changed the title feat: HitEvents feat: AttackAbility HitEvents Apr 18, 2025
@mawosl
Copy link
Author

mawosl commented Apr 18, 2025

@louis1706 switched event to generic for player
works with scp939, scp049-2
ngl i had like no clue what you wanted the entire time

@louis1706 louis1706 merged commit 1ce8463 into ExMod-Team:dev Apr 20, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants