-
Notifications
You must be signed in to change notification settings - Fork 104
feat: AttackAbility HitEvents #488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Can you verify than 939 don't trigger this event please |
|
939 does not trigger event now |
|
in transpiler why create a local variable that you never use and copy the eventargument and assign it to it. if you never use it, you can remove it |
|
removed unnecessary lines from transpiler (thanks @MS-crew :>) |
|
I still don't get why you make it only for Scp049-2 where you could have done it for all Scp with this AttackAbility |
|
@louis1706 switched event to generic for player |
Description
Describe the changes
New event for when SCP049-2 performs an attack (if hits target or not)
What is the current behavior? (You can also link to an open issue here)
None
What is the new behavior? (if this is a feature change)
New Event
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No
Other information:
Types of changes
Submission checklist
Patches (if there are any changes related to Harmony patches)
Other