Skip to content

Conversation

@GoldenPig1205
Copy link

Description

Describe the changes
Developers can interact more with the Exiled.API.Features.Warhead functions supported by Exiled.

Reuploaded due to mistake

What is the current behavior? (You can also link to an open issue here)
What is the new behavior? (if this is a feature change)
Start()
Stop()
Detonate()
Shake()
The functions have been changed to allow more interaction.

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
None

Other information:


Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentations

Submission checklist

  • I have checked the project can be compiled
  • I have tested my changes and it worked as expected

Patches (if there are any changes related to Harmony patches)

  • I have checked no IL patching errors in the console

Other

  • Still requires more testing

Copy link

@VALERA771 VALERA771 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use Player instead of RefHub

@GoldenPig1205 GoldenPig1205 requested a review from VALERA771 April 19, 2025 11:32
@GoldenPig1205 GoldenPig1205 requested a review from VALERA771 April 19, 2025 14:03
Copy link

@louis1706 louis1706 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR will cause ambiguous exception when compiling plugin

I would recommend removing the default value for the first argument

@GoldenPig1205 GoldenPig1205 requested a review from louis1706 April 19, 2025 17:27
@louis1706 louis1706 changed the base branch from master to dev April 19, 2025 17:44
@louis1706 louis1706 merged commit 834966a into ExMod-Team:dev Apr 19, 2025
6 checks passed
@GoldenPig1205 GoldenPig1205 deleted the pr1 branch April 19, 2025 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants