Skip to content

Conversation

@x3rt
Copy link

@x3rt x3rt commented Jun 13, 2025

Description

Describe the changes

  • Due to LabAPI adding PlayerDroppingItemEventArgs the index of the ItemPickupBase local has been shifted up one.

What is the current behavior? (You can also link to an open issue here)
Incorrect local is used (LabAPI's PlayerDroppingItemEventArgs is passed to the DroppedItemEventArgs ctor)

What is the new behavior? (if this is a feature change)
Correct local is used (ItemPickupBase is passed to the DroppedItemEventArgs ctor)

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No

Other information:


Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentations

Submission checklist

  • I have checked the project can be compiled
  • I have tested my changes and it worked as expected

Patches (if there are any changes related to Harmony patches)

  • I have checked no IL patching errors in the console

Other

  • Still requires more testing

@x3rt
Copy link
Author

x3rt commented Jun 13, 2025

FYI a lot of your transpilers suck (hard coded local indexes) and break because of that (Same reason RoundSummary._ProcessServerSideCode broke and had to be fixed)

I can't be bothered rewriting all/any of your transpilers knowing the PR would likely be denied.

I just fixed this Transpiler, but I did not future proof it so future updates may require it to be updated again.

If you wrote your Transpilers properly you wouldn't have these constant game-breaking problems :)

@obvEve obvEve merged commit d9a0896 into ExMod-Team:dev Jun 13, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants