Skip to content

Conversation

@MS-crew
Copy link

@MS-crew MS-crew commented Jun 13, 2025

Description

Describe the changes
Fix critical error

What is the current behavior? (You can also link to an open issue here)
When die as a custom role which is like role = none it kicks the player out of the server without giving any error, even when player log back in, get a black screen and nothing loads. Causes client error!

What is the new behavior? (if this is a feature change)
Fixed

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No

Other information:
https://discord.com/channels/656673194693885975/1375431933844262952/1375431933844262952

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentations

Submission checklist

  • I have checked the project can be compiled
  • I have tested my changes and it worked as expected

Patches (if there are any changes related to Harmony patches)

  • I have checked no IL patching errors in the console

Other

  • Still requires more testing

@MikeSus1
Copy link

@MS-crew Can you confirm to me this is tested and working ?

@MS-crew
Copy link
Author

MS-crew commented Jun 14, 2025

@MS-crew Can you confirm to me this is tested and working ?

@MikeSus1 Yes, now if the role is none or incompatible, the player's client doesn't crash.

@VALERA771 VALERA771 merged commit f9f3656 into ExMod-Team:dev Jun 18, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants