forked from Exiled-Official/EXILED
-
Notifications
You must be signed in to change notification settings - Fork 105
feat: Generic damage handler add new value #561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louis1706
requested changes
Jul 5, 2025
louis1706
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are doing breaking change here
Author
|
(information) This pr contains breaking changes and will wait until the next major release |
louis1706
approved these changes
Jul 7, 2025
louis1706
approved these changes
Jul 31, 2025
This was referenced Aug 4, 2025
This was referenced Sep 17, 2025
This was referenced Dec 17, 2025
This was referenced Jan 15, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes
Removes an unnecessary Hurt method overload and introduces a new configurable behavior for Cassie announcements triggered by player deaths.
What is the current behavior? (You can also link to an open issue here)
Cassie announcements are triggered on any player death . Additionally, the Hurt method had two overloads, which was unnecessary and potentially confusing. Also, there was no way to override Cassie behavior per Hurt call.
What is the new behavior? (if this is a feature change)
Developers can now choose to annoucment Cassie messages for non SCPs by setting overrideCassieForAllRole to true. Only one clean, flexible overload of Hurt remains, simplifying the API surface and supporting all use cases via optional parameters.
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No, all changes maintain full backward compatibility
Other information:
Types of changes
Submission checklist
Patches (if there are any changes related to Harmony patches)
Other