Skip to content

Conversation

@MS-crew
Copy link

@MS-crew MS-crew commented Jun 13, 2025

Description

Describe the changes
Removes an unnecessary Hurt method overload and introduces a new configurable behavior for Cassie announcements triggered by player deaths.

What is the current behavior? (You can also link to an open issue here)
Cassie announcements are triggered on any player death . Additionally, the Hurt method had two overloads, which was unnecessary and potentially confusing. Also, there was no way to override Cassie behavior per Hurt call.

What is the new behavior? (if this is a feature change)
Developers can now choose to annoucment Cassie messages for non SCPs by setting overrideCassieForAllRole to true. Only one clean, flexible overload of Hurt remains, simplifying the API surface and supporting all use cases via optional parameters.

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No, all changes maintain full backward compatibility

Other information:


Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentations

Submission checklist

  • I have checked the project can be compiled
  • I have tested my changes and it worked as expected

Patches (if there are any changes related to Harmony patches)

  • I have checked no IL patching errors in the console

Other

  • Still requires more testing

Copy link

@louis1706 louis1706 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are doing breaking change here

@MS-crew
Copy link
Author

MS-crew commented Jul 7, 2025

(information) This pr contains breaking changes and will wait until the next major release

@louis1706 louis1706 merged commit 0778174 into ExMod-Team:dev Jul 31, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants