fix: Scale fix

[Bonjemus]

Description

Describe the changes
Read title.

What is the current behavior? (You can also link to an open issue here)
Not stonks.

What is the new behavior? (if this is a feature change)
Stonks.

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Nah, I'd repair.

Other information:
I didn't fix SetFaceScale because of lazyness.
CustomRole has a delay because of an issue in 14.1.1 : https://discord.com/channels/330432627649544202/1274617943258566726/1384174712300765386

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Documentations

Submission checklist

• I have checked the project can be compiled
• I have tested my changes and it worked as expected

Patches (if there are any changes related to Harmony patches)

• I have checked no IL patching errors in the console

Other

• Still requires more testing

[louis1706]

I would recommend not modifying the player.Scale but instead adding FpcRole::Scale

[Someone-193]

I concur, tbh I think we need something like Dictionaries to track player scales to re-create pre 14.1.1 behavior, but Bonjemus said he wanted a way to not have scale persist so we should just add an overload for that in the SetScale method, we could also add a GetScale(Player observer) method for devs to get a players scale / fake scale after setting it

[Bonjemus]

I would recommend not modifying the player.Scale but instead adding FpcRole::Scale

That would be a breaking change, I don't get what you mean.

[Bonjemus]

I concur, tbh I think we need something like Dictionaries to track player scales to re-create pre 14.1.1 behavior, but Bonjemus said he wanted a way to not have scale persist so we should just add an overload for that in the SetScale method, we could also add a GetScale(Player observer) method for devs to get a players scale / fake scale after setting it

As aforementioned, maintaining the scale after a role change is sloppy and will lead to a lot of confusion/errors.

[Someone-193]

I would recommend not modifying the player.Scale but instead adding FpcRole::Scale

That would be a breaking change, I don't get what you mean.

Brother this PR is already a breaking change, my suggestion might be "sloppy and will lead to a lot of confusion/errors" but at least it would lead to non-breaking behavior with more features

[GoldenPig1205]

this update introduces a serious issue, where modifying Scale more than twice within a frame will cause the server to crash

[Bonjemus]

Yes, this is NW issue, yes, this was already talked in the message (read please) m, yes, some code (like in custom role) has been adjusted to avoid crashes. NW said it will be fixed next update. READ.