fix: fix goofy goober code Yamato didn't proofread #586
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes
some dude PR'd some async safe code for CR cuz he thought events were async and causing a crash so he rewrote CR spawn code, this just makes it synchronous again (cuz SL is synchronous) while still maintaining the rewrote spawn code
What is the current behavior? (You can also link to an open issue here)
Unnecessary async safe code + a field that should be a property
What is the new behavior? (if this is a feature change)
code is cleaner and likely more efficient
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
no, but I bet the PR this is fixing was 😝
Other information:
Types of changes
Submission checklist
Patches (if there are any changes related to Harmony patches)
Other