Skip to content

Conversation

@Someone-193
Copy link
Collaborator

Description

Describe the changes
some dude PR'd some async safe code for CR cuz he thought events were async and causing a crash so he rewrote CR spawn code, this just makes it synchronous again (cuz SL is synchronous) while still maintaining the rewrote spawn code

What is the current behavior? (You can also link to an open issue here)
Unnecessary async safe code + a field that should be a property

What is the new behavior? (if this is a feature change)
code is cleaner and likely more efficient

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
no, but I bet the PR this is fixing was 😝

Other information:


Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentations

Submission checklist

  • I have checked the project can be compiled
  • I have tested my changes and it worked as expected

Patches (if there are any changes related to Harmony patches)

  • I have checked no IL patching errors in the console

Other

  • Still requires more testing

@louis1706 louis1706 merged commit e6f1edf into ExMod-Team:dev Jul 6, 2025
6 checks passed
@Someone-193 Someone-193 deleted the FixStupidField branch December 20, 2025 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants