Skip to content

Conversation

@MS-crew
Copy link

@MS-crew MS-crew commented Aug 29, 2025

Description

Describe the changes
Fix

What is the current behavior? (You can also link to an open issue here)
Custom Weapons Broken

What is the new behavior? (if this is a feature change)
Fixed

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No

Other information:
Hello

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentations

Submission checklist

  • I have checked the project can be compiled
  • I have tested my changes and it worked as expected

Patches (if there are any changes related to Harmony patches)

  • I have checked no IL patching errors in the console

Other

  • Still requires more testing

@VALERA771
Copy link

VALERA771 commented Sep 6, 2025

I think we should remove classes rather than comment them.
Also did you test changes?

@MS-crew
Copy link
Author

MS-crew commented Sep 7, 2025

I think we should remove classes rather than comment them. Also did you test changes?

Yes, I tested it, the reason for committing is that we are using the Labapi event for the first time, so I think it is good to keep the main transpilers as a backup in case we give up.

@VALERA771 VALERA771 requested a review from louis1706 September 8, 2025 11:29
Copy link

@louis1706 louis1706 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove commented file before merge

@VALERA771 VALERA771 merged commit 13705bf into ExMod-Team:dev Sep 8, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants