Skip to content

Conversation

@MS-crew
Copy link

@MS-crew MS-crew commented Aug 29, 2025

Description

Describe the changes
Falling into the void at the Pocket Dimension exit

What is the current behavior? (You can also link to an open issue here)
If you went to the pocket dimension by teleportation or displacement, you would fall into the void.

What is the new behavior? (if this is a feature change)
If the position is invalid, a safe position is returned

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No

Other information:


Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentations

Submission checklist

  • I have checked the project can be compiled
  • I have tested my changes and it worked as expected

Patches (if there are any changes related to Harmony patches)

  • I have checked no IL patching errors in the console

Other

  • Still requires more testing

@MS-crew MS-crew changed the base branch from master to dev August 29, 2025 19:36
@louis1706
Copy link

Make default Scp106 room that would be better also add warning for it it's not normal than people get vector3.zero position (will probably remove it once we did report it to nw how to reproduce this)

@MS-crew MS-crew closed this Sep 2, 2025
@louis1706 louis1706 reopened this Sep 2, 2025
@VALERA771
Copy link

Are you sure that players won't be dropped into the void?

@MS-crew
Copy link
Author

MS-crew commented Sep 3, 2025

Are you sure that players won't be dropped into the void?

Hmm so yes, that bug is there for a part of it, but if you go to Pocket from a place where there is no room, you can still end up in the void. So, this only fixed part of it. Maybe we should check with trygetroom instead of Vector3 Zero.

@MS-crew MS-crew requested a review from louis1706 September 3, 2025 18:15
@louis1706 louis1706 merged commit 6cd70e7 into ExMod-Team:dev Sep 3, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

base-game-bug Bug from the main game Transpiler

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants