Skip to content

Conversation

@reversum
Copy link

@reversum reversum commented Dec 15, 2025

Description

Describe the changes

What is the current behavior? (You can also link to an open issue here)
MessageTranslated uses the wrong payload and therefore does not send subtitles, only the original message. In addition, MessageTranslated & Message uses “isHeld” where it should be isNoisy.

What is the new behavior? (if this is a feature change)
MessageTranslated now uses the correct CassieTtsPayload and sends the custom subtitles along with it. isNoisy is used in exactly the right places.

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No.

Other information:


Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentations

Submission checklist

  • I have checked the project can be compiled
  • I have tested my changes and it worked as expected

Patches (if there are any changes related to Harmony patches)

  • I have checked no IL patching errors in the console

Other

  • Still requires more testing

@github-actions github-actions bot added the API label Dec 15, 2025
@reversum reversum changed the title fix: cassie MessageTranslated & remove obsolete "isHeld" fix: cassie MessageTranslated & replace obsolete "isHeld" Dec 15, 2025
@louis1706
Copy link

you clearly didn't tested those there obvious issue on these

@Someone-193
Copy link
Collaborator

you clearly didn't tested those there obvious issue on these

I dont see them, can you quote them or something? Cuz this PR looks good to me

Copy link

@louis1706 louis1706 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also for all of them you modified isHeld by isNoisy but then you keep the isNoisy without replacing it to the isHeld i can get than there was swap but it's should both be used there not only isNoisy

@louis1706 louis1706 merged commit 73e59a8 into ExMod-Team:dev Dec 19, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants