Skip to content

fix: Fix Scp106PocketItemManager throwing a IndexOutOfRangeException#743

Merged
louis1706 merged 2 commits intoExMod-Team:devfrom
Someone-193:106-item-manager-fix
Feb 9, 2026
Merged

fix: Fix Scp106PocketItemManager throwing a IndexOutOfRangeException#743
louis1706 merged 2 commits intoExMod-Team:devfrom
Someone-193:106-item-manager-fix

Conversation

@Someone-193
Copy link

Description

Describe the changes
See title. @ me on discord if you want an in depth explanation of the bug.

What is the current behavior? (You can also link to an open issue here)

What is the new behavior? (if this is a feature change)

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Other information:
It's kinda hard to test this as there need to be 64 players connected + room identifiers when an item is picked up. I guess test this with dummies? Also it's kinda hard to test as well cuz the map is still borked from my Map.Generating fix not being merged yet

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentations

Submission checklist

  • I have checked the project can be compiled
  • I have tested my changes and it worked as expected

Patches (if there are any changes related to Harmony patches)

  • I have checked no IL patching errors in the console

Other

  • Still requires more testing

Copy link

@louis1706 louis1706 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would approve but still want to know if it's wouldn't be more optimised to just use ListPool like other Patch instead of using CodeMatcher

@louis1706 louis1706 merged commit 654290c into ExMod-Team:dev Feb 9, 2026
9 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

base-game-bug Bug from the main game Transpiler

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants