fix: Fix Scp106PocketItemManager throwing a IndexOutOfRangeException#743
Merged
louis1706 merged 2 commits intoExMod-Team:devfrom Feb 9, 2026
Merged
fix: Fix Scp106PocketItemManager throwing a IndexOutOfRangeException#743louis1706 merged 2 commits intoExMod-Team:devfrom
louis1706 merged 2 commits intoExMod-Team:devfrom
Conversation
louis1706
approved these changes
Feb 9, 2026
louis1706
left a comment
There was a problem hiding this comment.
i would approve but still want to know if it's wouldn't be more optimised to just use ListPool like other Patch instead of using CodeMatcher
louis1706
approved these changes
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes
See title. @ me on discord if you want an in depth explanation of the bug.
What is the current behavior? (You can also link to an open issue here)
What is the new behavior? (if this is a feature change)
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information:
It's kinda hard to test this as there need to be 64 players connected + room identifiers when an item is picked up. I guess test this with dummies? Also it's kinda hard to test as well cuz the map is still borked from my Map.Generating fix not being merged yet
Types of changes
Submission checklist
Patches (if there are any changes related to Harmony patches)
Other