Skip to content

feat: Sending & Receiving gun sound events#748

Merged
Someone-193 merged 11 commits intoExMod-Team:devfrom
MS-crew:SendingGunShot
Feb 12, 2026
Merged

feat: Sending & Receiving gun sound events#748
Someone-193 merged 11 commits intoExMod-Team:devfrom
MS-crew:SendingGunShot

Conversation

@MS-crew
Copy link

@MS-crew MS-crew commented Feb 9, 2026

Description

Describe the changes
read title

What is the current behavior? (You can also link to an open issue here)

What is the new behavior? (if this is a feature change)

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Other information:


Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentations

Submission checklist

  • I have checked the project can be compiled
  • I have tested my changes and it worked as expected

Patches (if there are any changes related to Harmony patches)

  • I have checked no IL patching errors in the console

Other

  • Still requires more testing

@MS-crew MS-crew marked this pull request as draft February 9, 2026 23:13
@Someone-193
Copy link

I see it's still a WIP, might I recommend putting ReceivingGunSound inside the foreach loop in ServerSendToNearbyPlayers that's just called for each ReferenceHub that passes the check required to send the audio RPC? I assume you've tested this (you checked the box in your PR) so nice job setting up a transpiler to work with the internal type thing 👍

i hate patching delegate
@MS-crew MS-crew marked this pull request as ready for review February 10, 2026 15:37
@Someone-193
Copy link

Did you really have to patch the internal type for the SendRpc call 😭
atp you might as well add a Position property to both event args and a ShooterVisible property to the receiving args

Copy link

@Someone-193 Someone-193 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work properly

@Someone-193 Someone-193 merged commit ffb7cb2 into ExMod-Team:dev Feb 12, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants