healthcheck: add support interface numbering #1215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clwluvw
force-pushed
the
interface-numbering
branch
from
4b0a244 to
87a6eb0
Compare
|
Please let me know when you are happy that the code is fine and I will review for merge. |
|
@thomas-mangin I guess that should be it. Happy to take your review. |
|
The name of the option is odd, isn't it? This could be |
clwluvw
force-pushed
the
interface-numbering
branch
from
87a6eb0 to
e42530c
Compare
So far loopback ips was looking for the corresponding interface by checking whether the label starts with the desired input. By providing --label-exact-match it checks whether the label exactly matches the desired input. Signed-off-by: Seena Fallah <seenafallah@gmail.com>
clwluvw
force-pushed
the
interface-numbering
branch
from
e42530c to
001873c
Compare
|
@vincentbernat LGTM |
|
@vincentbernat thank you for your time and the review ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far loopback ips was looking for the corresponding interface by checking whether the label starts with the desired input. By providing --use-interface-numbering it checks whether the label exactly matches the desired input.
Fixes: #1199