Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test if capability message is received as expected #1222

Conversation

ton31337
Copy link
Contributor

@ton31337 ton31337 commented Jul 9, 2024

No description provided.

@ton31337 ton31337 marked this pull request as draft July 9, 2024 16:36
@thomas-mangin
Copy link
Member

can I please ask you to reformat the function in another PR so I can see what changed please?

@thomas-mangin
Copy link
Member

thomas-mangin commented Jul 9, 2024

As the bgp program is changed, bgp-3.6 will also be updated to match the changes. Otherwise, I will have no chance to make Python 3.6 build stable. ATM, they fail once in a while, but I do not know why (and I need to build an old Ubuntu to debug), so I have left it for later.

ton31337 added 2 commits July 9, 2024 19:42
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
@thomas-mangin
Copy link
Member

Forget my comment about formatting ..

@ton31337 ton31337 force-pushed the feature/add_a_test_for_hostname_capability branch from cf3403f to 696a27f Compare July 9, 2024 16:42
@ton31337
Copy link
Contributor Author

ton31337 commented Jul 9, 2024

I can drop that reformatting commit for sure, should I drop it or leave it as it is now?

@ton31337 ton31337 marked this pull request as ready for review July 9, 2024 16:44
@thomas-mangin
Copy link
Member

Leave, it - I am just trying to understand why your code works :-)
Just need the same patch to ibgp-3.6

@ton31337
Copy link
Contributor Author

ton31337 commented Jul 9, 2024

Will do in a minute ;)

@thomas-mangin
Copy link
Member

ok, it does not allow to test for an OPEN and then an UPDATE - that's ok, it can be added later. It does not break anything.

@ton31337
Copy link
Contributor Author

ton31337 commented Jul 9, 2024

Gh, don't have 3.6 right now...

@thomas-mangin thomas-mangin merged commit b7304a7 into Exa-Networks:main Jul 14, 2024
15 of 16 checks passed
@ton31337 ton31337 deleted the feature/add_a_test_for_hostname_capability branch July 14, 2024 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants