Invalid #1233
Closed
Invalid #1233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…2-backport Fix cache on clear command 4.2 backport
Otherwise some packets can still be routed to the server which is going to refuse them.
…_4.2 healthcheck: remove loopback ips after sending BGP announce
- Change order of arguments to match the script output - Remove folder arg - Add and document root, run, validate arguments
- Grammar on openwait environment - Change exabgp to ExaBGP in usage help for consistency with the line below
4.2 Fix the man page and text tweaks
Fixes the following traceback when running ExaBGP as daemon:
Traceback (most recent call last):
File "/usr/local/bin/exabgp", line 8, in <module>
sys.exit(run_exabgp())
File "/usr/local/lib/python3.8/dist-packages/exabgp/application/__init__.py", line 20, in run_exabgp
main()
File "/usr/local/lib/python3.8/dist-packages/exabgp/application/bgp.py", line 314, in main
run(env, comment, configurations, root, options["--validate"])
File "/usr/local/lib/python3.8/dist-packages/exabgp/application/bgp.py", line 388, in run
exit_code = Reactor(configurations).run(validate, root)
File "/usr/local/lib/python3.8/dist-packages/exabgp/reactor/loop.py", line 226, in run
self.daemon.daemonise()
File "/usr/local/lib/python3.8/dist-packages/exabgp/reactor/daemon.py", line 188, in daemonise
if self._is_socket(sys.__stdin__.fileno()) or os.getppid() == 1:
File "/usr/local/lib/python3.8/dist-packages/exabgp/reactor/daemon.py", line 158, in _is_socket
s = socket.fromfd(fd, socket.AF_INET, socket.SOCK_RAW)
File "/usr/lib/python3.8/socket.py", line 544, in fromfd
return socket(family, type, proto, nfd)
File "/usr/lib/python3.8/socket.py", line 231, in __init__
_socket.socket.__init__(self, family, type, proto, fileno)
OSError: [Errno 88] Socket operation on non-socket
Fix the following configuration parsing error: configuration | error message: illegal IP address string passed to inet_pton
daemon: fix socket validation traceback on startup
Add --*-as-path options to change as-path on healthcheck status. #1007
update/traffic: fix IPv6 translation
…o work with offline neighbors
…bors Refactor how config routes are deleted from outgoing RIB to handle offline routers
…le.ch/exabgp/master
|
No worries. main/master is ahead of 4.2.22 as many features have not been backported. Mostly as some changes are not fully backward compatible. It is at a point where it would justify a 5.0.0 release but I have been holding it back. |
|
For clarity, there is no fix in 4.2.22 which is not already in main. Some backports may have required a different implementation because the code base diverged over time. main can be used in production as it sees the same care for stability as 4.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please delete.