Exclude path attributes from MP_UNREACH_NLRI only messages #968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since the master branch seems to encounter the same errors as this PR, and because the same tests work locally, I shall assume that the failed Travis tests are not my doing. |
thomas-mangin
added a commit
to thomas-mangin/exabgp
that referenced
this pull request
May 16, 2020
|
Sorry, due to the use of black of the patch could could not be merged as it. Manually merged it. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #967.
I implemented this knowing little about ExaBGP's code base, so I'm not sure this suffices. I did verify that all tests still succeed, so there's at least that.
I also did try to add a test for this specific case, but I didn't quite understand how to best approach this and after some tries I gave up.
We did run this change in our lab and in two separate developer environments, observing the effects, testing general functionality, and looking at the messages on the wire. We observed the desired effects and it solves our problem.
As this issue is of some importance to us, because it solves a real issue we face, we would appreciate it a lot if this PR could be reviewed, merged, and released swiftly. Though it has to be said that this is not a bug in ExaBGP. It would simply be really nice 🙂.
Let me know how we can support you, and do get back to me if you want me to change or add something.