Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/SOF-7442 feat: detect local z extremum #157

Merged
merged 7 commits into from
Sep 11, 2024
Merged

Conversation

VsevolodX
Copy link
Member

@VsevolodX VsevolodX commented Aug 28, 2024

Detects atom with highest or lowest Z coordinate for provided (x,y,z) within a range -- for correct local surface atom detection to place adatoms on a lower terrace step, to get the correct Z-coordinate for passivation or absorption.

  • update: add local z extremum search
  • update: correctly handle cartesian coordinates

@VsevolodX VsevolodX changed the base branch from main to feature/SOF-7413 August 28, 2024 17:18

Args:
material (Material): Material object.
coordinate (List[float]): (x, y, z) coordinate to find the local extremum.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

coordinate to find the local extremum atom index for

Base automatically changed from feature/SOF-7413 to main September 11, 2024 00:49
@VsevolodX VsevolodX merged commit 910c6a2 into main Sep 11, 2024
9 checks passed
@VsevolodX VsevolodX deleted the feature/SOF-7442 branch September 11, 2024 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants