Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clipped outflow made default for momentum equation #1340

Merged
merged 6 commits into from
Nov 14, 2024

Conversation

mbkuhn
Copy link
Contributor

@mbkuhn mbkuhn commented Nov 11, 2024

Summary

This change should have been in #1287, but it was missed. Because of that, inflow at outflow was still automatically allowed in the momentum equation (ICNS). This removes that; changing the default to a clipped outflow (clipping velocities going into the domain)

Pull request type

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Checklist

The following is included:

  • new unit-test(s)
  • new regression test(s)
  • documentation for new capability

This PR was tested by running:

  • the unit tests
    • on GPU
    • on CPU
  • the regression tests
    • on GPU
    • on CPU

Additional background

This should actually cause the diffs I expected in the other PR...

@mbkuhn mbkuhn requested a review from marchdf November 11, 2024 16:48
@mbkuhn
Copy link
Contributor Author

mbkuhn commented Nov 11, 2024

won't merge until feedback on issue #1341

@mbkuhn
Copy link
Contributor Author

mbkuhn commented Nov 11, 2024

@marchdf would you say the CI is acting up again? see the CPU fails

@marchdf
Copy link
Contributor

marchdf commented Nov 11, 2024

yeah this kind of thing:what(): UtilCreateCleanDirectory:: std::rename failed makes me thing there's something up with the CI filesystem. Let's see if it clears up. I wouldn't worry unless this keeps up

@mbkuhn mbkuhn enabled auto-merge (squash) November 14, 2024 22:58
@mbkuhn mbkuhn merged commit 2b309bd into Exawind:main Nov 14, 2024
15 checks passed
@mbkuhn
Copy link
Contributor Author

mbkuhn commented Nov 14, 2024

At the moment, issue #1341 appears to be caused by something else, and it is more setup-related. This PR doesn't fix that problem, but this PR needed to go in either way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants